Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Wait for cloud-init to complete before pkg cache is updated #3238

Closed
wants to merge 1 commit into from

Conversation

trstringer
Copy link
Contributor

What this PR does / why we need it: This makes the cluster provisioning wait until cloud-init configuration has completed prior to updating the cache. A part of the cloud-init configuration includes adding apt source (templating), and it appears as though there was a race condition causing transient failures (for more information, please see #3204).

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #3204

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Fix race condition for pkg cache updating prior to cloud-init completion

@acs-bot
Copy link

acs-bot commented Jun 8, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: trstringer
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: brendandburns

Assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot added the size/XS label Jun 8, 2018
@jackfrancis
Copy link
Member

@trstringer Thanks! Your analysis is probably spot on! We already have #3230 gathering test data, and it accomplishes the same thing (in another way, by moving the apt-get update into a func that is invoked after cloud-init)

@jackfrancis jackfrancis closed this Jun 8, 2018
@trstringer
Copy link
Contributor Author

@jackfrancis ok cool, thanks!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transient CSE exit code 9 on VMSS with k8s 1.10
3 participants