This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Docs: Update user guide list to include Windows, update description of clusters #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
README.md
Outdated
| These guides show how to create your first deployment for each orchestrator: | ||
| * [ACS Engine](docs/acsengine.md) - shows you how to build and use the ACS engine to generate custom container clusters | ||
| * [DC/OS Walkthrough](docs/dcos.md) - shows how to create a DC/OS cluster on Azure | ||
| * [Kubernetes Walkthrough](docs/kubernetes.md) - shows how to create a Kubernetes cluster on Azure |
There was a problem hiding this comment.
I think some docs in Kubernetes Walkthrough applies to both Linux and Windows, maybe it'd make more sense to add the link for Windows inside that page instead so that the readme links to the general Kubernetes docs and then the user can go to instructions for windows from there.
README.md
Outdated
| @@ -19,13 +19,17 @@ The cluster definition file enables you to customize your Docker enabled cluster | |||
|
|
|||
| ## User guides | |||
|
|
|||
| * [ACS Engine](docs/acsengine.md) - shows you how to build and use the ACS engine to generate custom Docker enabled container clusters | |||
| These guides show how to create your first deployment for each orchestrator: | |||
| * [ACS Engine](docs/acsengine.md) - shows you how to build and use the ACS engine to generate custom container clusters | |||
There was a problem hiding this comment.
This one is general, not specific to an orchestrator so maybe it can go up one line
Codecov Report
@@ Coverage Diff @@
## master #3473 +/- ##
==========================================
+ Coverage 55.45% 55.84% +0.39%
==========================================
Files 105 105
Lines 16036 15889 -147
==========================================
- Hits 8892 8874 -18
+ Misses 6393 6270 -123
+ Partials 751 745 -6 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PatrickLang If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
force-pushed
the
plang-wintoc
branch
from
36007a1
to
7acd496
Compare
PaulCharlton
added a commit
to ElementAnalytics/acs-engine
that referenced
this pull request
Jul 26, 2018
* 'master' of https://github.com/Azure/acs-engine: (59 commits) Docs: Update user guide list to include Windows, update description of clusters (Azure#3473) update to Azure CNI v1.0.10 (Azure#3551) Adding 'make dev' equivalent for Windows (Azure#3471) print out ubuntu ver in e2e (Azure#3555) fix an issue where networkPlugin was not defined correctly when using calico or cilium (Azure#3271) Bump ginkgo to a tagged release (Azure#3554) Reenable AzureFile tests for Windows on K8s 1.11.1, resolves Azure#3439 (Azure#3496) removing rbac error checking from merge fn (Azure#3530) Change dns healthcheck to look at external domain (Azure#3282) DOCUMENTATION: Fix Documented Default Value for clusterSubnet (Azure#3474) Document required manual calico 2.6.3 -> calico 3.1.1 upgrade when upgrading from < 0.17.0-provisioned clusters (Azure#3208) revert --image-pull-policy=IfNotPresent for win (Azure#3553) --image-pull-policy=IfNotPresent for kubectl run commands (Azure#3552) Kubernetes: --max-pods=30 should be Azure CNI-only (Azure#3543) disable Azure CNI network monitor addon default (Azure#3550) only do az vm list for k8s (Azure#3540) Retire Swarm E2E for PR test coverage (Azure#3539) retire Azure CDN for container image repository proxying (Azure#3535) removed datadisk to allow scale after upgrade (Azure#3482) Pump k8s-azure-kms version (Azure#3531) ...
PaulCharlton
added a commit
to ElementAnalytics/acs-engine
that referenced
this pull request
Jul 26, 2018
* master: (59 commits) Docs: Update user guide list to include Windows, update description of clusters (Azure#3473) update to Azure CNI v1.0.10 (Azure#3551) Adding 'make dev' equivalent for Windows (Azure#3471) print out ubuntu ver in e2e (Azure#3555) fix an issue where networkPlugin was not defined correctly when using calico or cilium (Azure#3271) Bump ginkgo to a tagged release (Azure#3554) Reenable AzureFile tests for Windows on K8s 1.11.1, resolves Azure#3439 (Azure#3496) removing rbac error checking from merge fn (Azure#3530) Change dns healthcheck to look at external domain (Azure#3282) DOCUMENTATION: Fix Documented Default Value for clusterSubnet (Azure#3474) Document required manual calico 2.6.3 -> calico 3.1.1 upgrade when upgrading from < 0.17.0-provisioned clusters (Azure#3208) revert --image-pull-policy=IfNotPresent for win (Azure#3553) --image-pull-policy=IfNotPresent for kubectl run commands (Azure#3552) Kubernetes: --max-pods=30 should be Azure CNI-only (Azure#3543) disable Azure CNI network monitor addon default (Azure#3550) only do az vm list for k8s (Azure#3540) Retire Swarm E2E for PR test coverage (Azure#3539) retire Azure CDN for container image repository proxying (Azure#3535) removed datadisk to allow scale after upgrade (Azure#3482) Pump k8s-azure-kms version (Azure#3531) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a link to the Windows Kubernetes howto, and also organizes the user guide list to clearly separate per-orchestrator tutorials from the more advanced customizations.