Docs - simplifying Windows walkthrough #3614

PatrickLang · 2018-08-04T01:01:42Z

What this PR does / why we need it:

The Windows walkthrough had a lot of back & forth from other pages which made it hard to follow.

This is my attempt at making a simpler top to bottom, copy & paste workflow. I'm not a great writer, so any and all feedback (or PRs) are welcome!

Special notes for your reviewer:

If applicable:

documentation

PatrickLang · 2018-08-04T01:03:20Z

@jsturtevant @jldeen @cwilhit @rpsqrd @sauryadas - any feedback on this doc update?

PatrickLang · 2018-08-04T01:04:13Z

/hold

I'll squash this before final merge

codecov · 2018-08-04T01:21:16Z

Codecov Report

Merging #3614 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3614      +/-   ##
==========================================
- Coverage   55.77%   55.72%   -0.05%     
==========================================
  Files         107      107              
  Lines       16238    16238              
==========================================
- Hits         9057     9049       -8     
- Misses       6408     6417       +9     
+ Partials      773      772       -1

jsturtevant

Looks much simpler. Left a few comments inline

jsturtevant · 2018-08-06T18:06:43Z

docs/kubernetes/windows.md


-Note, with the rollout of new Windows Server versions in acs-engine, the workload deployed on Windows cluster should match as documented here: https://docs.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/version-compatibility . Both the containers being deployed,
-as well as the `kubletwin/pause` container must match the version of the Windows host. Otherwise, [pods may get stuck at ContainerCreating](https://docs.microsoft.com/en-us/virtualization/windowscontainers/kubernetes/common-problems#my-kubernetes-pods-are-stuck-at-containercreating) state.
+- Getting the right tools


I find adding links to each section is help for folks to jump to a section they want to read about.

Found a VS Code extension for that :)

jsturtevant · 2018-08-06T18:10:40Z

docs/kubernetes/windows.md

+
+2. Find the latest version, and download the file ending in `-windows-amd64.zip`.
+
+3. Make a folder, and copy `acs-engine.exe` from the ZIP there


reword to something like "Extract the download to a folder in a working directory such as `c:\tools
acs-engine"

Thanks! done

jsturtevant · 2018-08-06T18:11:37Z

docs/kubernetes/windows.md

+
+3. Make a folder, and copy `acs-engine.exe` from the ZIP there
+
+4. Check that it runs with `.\acs-engine.exe version`


Add an additional/optional step to add to PATH

Thanks! done

jsturtevant · 2018-08-06T18:12:24Z

docs/kubernetes/windows.md


-Offer                    Publisher                      Sku                                             Urn                                                                                                            Version
-----------------------  -----------------------------  ----------------------------------------------  -------------------------------------------------------------------------------------------------------------  -----------------
+If it does not exist, then run `ssh-keygen.exe`. Use the default file, and enter a passphrase if you wish to protect it. Be sure not to use a SSH key with blank passphrase in production.


I think they might need putty installed to run this command? Should point that out.

I have this on a clean machine:

Directory: C:\Windows\system32\OpenSSH Mode LastWriteTime Length Name ---- ------------- ------ ---- -a---- 3/10/2018 10:20 AM 343552 scp.exe -a---- 3/10/2018 10:20 AM 408064 sftp.exe -a---- 3/10/2018 10:20 AM 531968 ssh-add.exe -a---- 3/10/2018 10:20 AM 495616 ssh-agent.exe -a---- 3/10/2018 10:20 AM 657920 ssh-keygen.exe -a---- 3/10/2018 10:20 AM 594944 ssh-keyscan.exe -a---- 3/10/2018 10:20 AM 894464 ssh.exe

must be included with the latest windows 10?

jsturtevant · 2018-08-06T18:14:51Z

docs/kubernetes/windows.md


-2. a set of windows and linux nodes.  The windows nodes can be accessed through an RDP SSH tunnel via the master node.  To do this, follow these [instructions](../ssh.md#ssh-to-the-machine), replacing port 80 with 3389.  Since your windows machine is already using port 3389, it is recommended to use 3390 to Windows Node 0, 10.240.0.4, 3391 to Windows Node 1, 10.240.0.5, and so on as shown in the following image:
+### Get an acs-engine apimodel


Would just call this "create an acs-engine apimodel"

jsturtevant · 2018-08-06T18:24:24Z

docs/kubernetes/windows.md

-#### 4. Enter the pod container to validate
+#### Get Kubectl for Windows
+
+The latest release of Kubernetes Control (kubectl) is available on the [Kubernetes release page](https://kubernetes.io/docs/imported/release/notes/). Look for `kubernetes-client-windows-amd64.tar.gz` and download it.


I would move this the first section "getting the right tools"

jsturtevant · 2018-08-06T18:24:49Z

docs/kubernetes/windows.md

+
+The latest release of Kubernetes Control (kubectl) is available on the [Kubernetes release page](https://kubernetes.io/docs/imported/release/notes/). Look for `kubernetes-client-windows-amd64.tar.gz` and download it.
+
+Windows 10 version 1803 already includes `tar`, so extract the archive and move `kubectl.exe` to your local path


what if they are not on 1803?

Upgrade :) I also added a link to busybox which will work

busybox like the linux image?

jsturtevant · 2018-08-06T19:38:21Z

docs/kubernetes/windows.md

-Workaround:
-1.	Use the FQDN in DNS lookups such as `kubernetes.kube-system.svc.cluster.local`
-2.	Instead of DNS, use environment variables `* _SERVICE_HOST` and `*_SERVICE_PORT` to find service IPs and ports in the same namespace
+Once the pod is in `Running` state, get the IP from `kubectl get service` then visit `http://<external-ip>` to test your web server.


explicitly call this external IP from the output above

ok clarified it

jsturtevant · 2018-08-06T19:40:29Z

examples/windows/kubernetes.json

+        "osDiskSizeGB": 127,
+        "extensions": [
+            {
+                "name": "winrm"


create a link the getting started on how to use winrm extension and why it is added.

jsturtevant · 2018-08-06T19:41:34Z

docs/kubernetes/windows-details.md

+
+### Changing the OS disk size
+
+The Windows Server deployments default to 30GB for the OS drive (C:), which may not be enough. You can change this size by adding `osDiskSizeGB` under the `agentPoolProfiles`, such as:


Add note on why this won't be enough. We have run into this in every engagement we have done.

Should we consider setting larger VM as a default?

Added more about disk sizes and updated agentPoolProfiles. I don't think I want to change the default VM size yet - with process isolation they will probably run out of pod IP addresses before containers fail to start.

jldeen · 2018-08-07T05:27:11Z

Hi, Apologies - i was OOO due to moving today. I glanced over it tonight, but will send in more thought-out comments tomorrow!

…

On Aug 3, 2018, at 18:03, Patrick Lang ***@***.*** ***@***.***>> wrote: @jsturtevant <https://github.com/jsturtevant> @jldeen <https://github.com/jldeen> @cwilhit <https://github.com/cwilhit> @rpsqrd <https://github.com/rpsqrd> - any feedback on this doc update? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3614 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHUhNtwKVap8QXnIUN29PJYhBYYXSwsTks5uNPLbgaJpZM4Vuxmn>.

timmydo · 2018-08-07T18:42:27Z

docs/kubernetes/windows.md

+Windows 10 version 1803 already includes `tar`, so extract the archive and move `kubectl.exe` to your local path
+
+```powershell
+tar xvzf C:\Users\patrick\Downloads\kubernetes-client-windows-amd64.tar.tar


That's not a typo. That's reflecting what Edge actually named the file. I'll go ahead and change it to .tar.gz to be less confusing and hope people can figure it out :)

derekbekoe · 2018-08-07T23:34:51Z

docs/kubernetes/windows.md


+```powershell
+dir ~/.ssh/id_rsa.pub


Should this have backslashes?

With forward slashes, I get this if the file doesn't exist:

$ dir ~/.ssh/id_rsa.pub Invalid switch - ".ssh".

weird, both work for me. I'll change it though.

derekbekoe · 2018-08-07T23:47:10Z

docs/kubernetes/windows.md


-In the image above, you can see the following parts:
+1. Set windowsProfile.adminUsername and adminPassword


Suggest: Link to https://docs.microsoft.com/en-us/azure/virtual-machines/windows/faq?toc=%2fazure%2fvirtual-machines%2fwindows%2ftoc.json#what-are-the-username-requirements-when-creating-a-vm so they don't fall into this trap. Same with password.

Great! I didn't know that was documented

I should fix this in acs-engine #3636

jldeen

just a few minor things to consider - those performing a Win k8s deployment may not be using a Windows platform to generate those templates. Include commands for both/all 3 - linux, windows, macOS

jldeen · 2018-08-08T21:57:03Z

docs/kubernetes/windows-details.md

+        "availabilityProfile": "AvailabilitySet",
+        "osType": "Windows",
+        "osDiskSizeGB": 128
+     }


Perhaps we should update the ARM template with the appropriate osDiskSizeGB specification, rather than requiring the end user to do it.

Yeah - the template from the quick start guide is updated too

jldeen · 2018-08-08T22:07:10Z

docs/kubernetes/windows-details.md

+            "windowsOffer": "WindowsServerSemiAnnual",
+            "windowsSku": "Datacenter-Core-1803-with-Containers-smalldisk"
+     },
+```


Should we also have this set in the default kubernetes.json here: https://github.com/Azure/acs-engine/blob/master/examples/windows/kubernetes.json? That way we have a template pre-configured and the end user can change if he/she/they wishes.

jldeen · 2018-08-08T22:08:48Z

docs/kubernetes/windows-details.md

+               0 File(s)              0 bytes
+               2 Dir(s)   5,368,709,120 bytes free
+
+```


This might sound silly, but should we include examples for both Windows and Linux commands/file paths? I can definitely see scenarios where those on macOS / linux still might want to deploy a Windows K8s cluster.

jldeen · 2018-08-08T22:09:59Z

docs/kubernetes/windows-details.md

+
+## Troubleshooting
+
+Windows support is still in active development with many changes each week. Read on for more info on known per-version issues and troubleshooting if you run into problems.


I recommend putting "active development" in bold to ensure those reading these docs are fully aware.

jldeen · 2018-08-08T22:13:14Z

docs/kubernetes/windows.md


-#### Changing the OS disk size
+Click the [download](https://aka.ms/installazurecliwindows) link, and choose "Run". Click through the setup steps as needed.


Add links for linux and macOS az cli installs, too. Just in case they are a sysadmin tasked with managing both *nix and Windows applications and use an alternative platform for the Win K8s template generation / creation.

jldeen · 2018-08-08T22:35:25Z

docs/kubernetes/windows.md

-	mode
-	dns.Nameservers
-	dns.Search
+```powershell


platform agnostic

jldeen · 2018-08-08T22:36:27Z

docs/kubernetes/windows.md


-Affects: Azure CNI plugin <= 0.3.0
+Now, you can check the status of the pod and service with `.\kubectl.exe get pod` and `.\kubectl.exe get service` respectively.


or just kubectl get pod AND kubectl get service to make more platform agnostic

jldeen · 2018-08-08T22:36:44Z

docs/kubernetes/windows.md

-Workaround:
-1.	Use the FQDN in DNS lookups such as `kubernetes.kube-system.svc.cluster.local`
-2.	Instead of DNS, use environment variables `* _SERVICE_HOST` and `*_SERVICE_PORT` to find service IPs and ports in the same namespace
+```powershell


again make this and the below just platform independent

jldeen · 2018-08-08T22:36:57Z

docs/kubernetes/windows.md


+PS C:\tools> .\kubectl.exe get service


same, platform independent

jldeen · 2018-08-08T22:38:14Z

docs/kubernetes/windows.md


-Affects: All acs-engine deployed clusters
+The service will eventually show an EXTERNAL-IP as well:
+```powershell


same as platform agnostic comments above

Adding group, SP creation Change default to v1.10 Adding winrm extension and VM resize to default sample Adding more steps Fixing output Fixing keyData Finishing quickstart steps, still working on the rest More doc cleanup Windows kubectl steps Finishing first deployment section Removing old steps Splitting out quick start from long details Fixing anchor links Clarify disk size recommendation, and make the 2 most common examples consistent with docs Add TOC Clarify extract and add optional step of adding to PATH s/\//\\/ Change get an apimodel to create an apimodel Adding username/password requirements More script goodies Be more polite about JSON Use existing kubeconfig/..json Adding tar alternative Clarify service & external IP Adding active development caveat

PatrickLang · 2018-08-09T00:31:42Z

Ok, just squashed my first version and all feedback into 1 commit. I'm adding a few more re: multiplatform now

PatrickLang · 2018-08-09T19:54:46Z

Alright, Mac/Linux instructions there and ready for a review. @jldeen and @mboersma can you take a look?

mboersma · 2018-08-09T20:03:55Z

docs/kubernetes/windows-details.md

+
+It will run 2 containers:
+
+- iis-container: This is a basic static web serber


Typo: "serber" -> "server"

needle in the haystack. fixed!

mboersma

Great stuff! I just had minor grammar touchups to point out.

mboersma · 2018-08-10T15:28:27Z

docs/kubernetes/windows-details.md

@@ -0,0 +1,335 @@
+# More on Windows and Kubernetes
+
+If you're trying to deploy Kubernetes with Windows the first time, be sure to check out the [quick start](windows.md) first. If you're looking for more details on deployments, examples or troubleshooting read on.


I would end this sentence using an em-dash:
...examples or troubleshooting--read on.

Thanks! fixed in new changelist

mboersma · 2018-08-10T15:30:14Z

docs/kubernetes/windows-details.md

+
+## Customizing Windows deployments
+
+ACS-Engine allows a lot more customizations available in the [docs](../), but here are a few important ones you should know for Windows deployments. Each of these are extra parameters you can add into the ACS-Engine apimodel file (such as kubernetes-windows.json from the quick start) before running `acs-engine generate`


Maybe put backticks around the filename kubernetes-windows.json? Also the final sentence needs a period.

Thanks! fixed in new changelist

mboersma · 2018-08-10T15:31:49Z

docs/kubernetes/windows-details.md

+
+### Changing the OS disk size
+
+The Windows Server deployments default to 30GB for the OS drive (C:), which is not enough to pull multiple `microsoft/windowsservercore` based containers. It's easiest to start with 128GB, then see what your usage is over time before shrinking it down. You can change this size by adding `osDiskSizeGB` under the `agentPoolProfiles`, such as:


This phrase in the first sentence should be punctuated with a dash:
microsoft/windowsservercore-based containers.

Thanks! fixed in new changelist

mboersma · 2018-08-10T15:33:22Z

docs/kubernetes/windows-details.md

+
+### Choosing the Windows Server version
+
+If you want to deploy a specific Windows Server version, you can. First, find available versions with `az vm image list --publisher MicrosoftWindowsServer --all -o table`


Rather than repeat the command twice, maybe this sentence could end this way:

First, find available versions with an az vm image list command:

Thanks! fixed in new changelist

mboersma · 2018-08-10T15:34:05Z

docs/kubernetes/windows-details.md

+WindowsServerSemiAnnual  MicrosoftWindowsServer         Datacenter-Core-1803-with-Containers-smalldisk  MicrosoftWindowsServer:WindowsServerSemiAnnual:Datacenter-Core-1803-with-Containers-smalldisk:1803.0.20180504  1803.0.20180504
+```
+
+You can use the Offer, Publisher and Sku to pick a specific version by adding `windowsOffer`, `windowsPublisher`, `windowsSku` and (optionally) `widndowsVersion` to the `windowsProfile` section. In this example, the latest Windows Server version 1803 image would be deployed.


Typo: widndowsVersion

mboersma · 2018-08-10T15:35:27Z

docs/kubernetes/windows-details.md

+kubectl get pvc/pvc-azurefile -o wide
+```
+
+5. Create a pod with azure file pvc


Maybe link to pod documentation here?

Thanks! fixed in new changelist

mboersma · 2018-08-10T15:37:34Z

docs/kubernetes/windows-details.md

+
+6. Watch the status of pod until its `STATUS` is `Running`
+```
+watch kubectl get po/iis-azurefile -o wide


I don't seem to have watch installed on macOS High Sierra. Maybe this command could use kubectl -w instead? I know its output gets muddled, but that would be more portable.

Thanks! fixed in new changelist

mboersma · 2018-08-10T15:39:20Z

docs/kubernetes/windows-details.md

+
+## Troubleshooting
+
+Windows support is still in **active development** with many changes each week. Read on for more info on known per-version issues and troubleshooting if you run into problems.


Maybe change the end of the final sentence to:

per-version issues and for help with troubleshooting if you run into problems.

Thanks! fixed in new changelist

mboersma · 2018-08-10T15:40:08Z

docs/kubernetes/windows-details.md

+There is a problem with the “L2Tunnel” networking mode not forwarding packets correctly specific to Windows Server version 1803. Windows Server version 1709 is not affected.
+
+Workarounds:
+**Fixes are still in development.** A Windows hotfix is needed, and willbe deployed by ACS-Engine once it's ready. The hotfix will be removed later when it's in a future cumulative rollup.


Typo: "willbe" -> "will be"

Thanks! fixed in new changelist

mboersma · 2018-08-10T15:41:39Z

docs/kubernetes/windows-details.md

+
+#### Pods cannot ping default route or internet IPs
+
+Affects: All acs-engine deployed clusters


This should be a hyphenated phrase ending with -deployed, but that would read poorly. Maybe change to:

Affects: All clusters deployed by acs-engine

Thanks! fixed in new changelist

jackfrancis · 2018-08-15T23:39:22Z

/lgtm

acs-bot · 2018-08-15T23:39:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, PatrickLang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ghost assigned PatrickLang Aug 4, 2018

ghost added the in progress label Aug 4, 2018

acs-bot added the size/L label Aug 4, 2018

acs-bot added size/XL and removed size/L labels Aug 4, 2018

jsturtevant reviewed Aug 6, 2018

View reviewed changes

timmydo reviewed Aug 7, 2018

View reviewed changes

derekbekoe reviewed Aug 8, 2018

View reviewed changes

jldeen reviewed Aug 8, 2018

View reviewed changes

acs-bot added size/XXL and removed size/XL labels Aug 9, 2018

Patrick Lang added 2 commits August 8, 2018 17:30

Make it multi platform

46645f8

PatrickLang force-pushed the plang-windowsquickstart branch from 69bed75 to 46645f8 Compare August 9, 2018 00:31

Patrick Lang added 3 commits August 8, 2018 18:07

Adding OpenSSH-portable download instructions

9c8f991

Adding prerequisites for Mac & Linux

c10b4c8

Last Mac/Linux TODOs

40a7d12

mboersma reviewed Aug 9, 2018

View reviewed changes

Fix typo. Now you know I'm on a qwerty keyboard

6a27b45

mboersma approved these changes Aug 10, 2018

View reviewed changes

More grammatical fixes

26f288c

acs-bot assigned jackfrancis Aug 15, 2018

acs-bot added the lgtm label Aug 15, 2018

acs-bot added the approved label Aug 15, 2018

jackfrancis merged commit 3a8cba6 into Azure:master Aug 16, 2018

ghost removed the in progress label Aug 16, 2018

PatrickLang deleted the plang-windowsquickstart branch August 16, 2018 00:47


		2. Find the latest version, and download the file ending in `-windows-amd64.zip`.

		3. Make a folder, and copy `acs-engine.exe` from the ZIP there


		3. Make a folder, and copy `acs-engine.exe` from the ZIP there

		4. Check that it runs with `.\acs-engine.exe version`


		2. a set of windows and linux nodes. The windows nodes can be accessed through an RDP SSH tunnel via the master node. To do this, follow these [instructions](../ssh.md#ssh-to-the-machine), replacing port 80 with 3389. Since your windows machine is already using port 3389, it is recommended to use 3390 to Windows Node 0, 10.240.0.4, 3391 to Windows Node 1, 10.240.0.5, and so on as shown in the following image:
		### Get an acs-engine apimodel


		The latest release of Kubernetes Control (kubectl) is available on the [Kubernetes release page](https://kubernetes.io/docs/imported/release/notes/). Look for `kubernetes-client-windows-amd64.tar.gz` and download it.

		Windows 10 version 1803 already includes `tar`, so extract the archive and move `kubectl.exe` to your local path


		### Changing the OS disk size

		The Windows Server deployments default to 30GB for the OS drive (C:), which may not be enough. You can change this size by adding `osDiskSizeGB` under the `agentPoolProfiles`, such as:


		In the image above, you can see the following parts:
		1. Set windowsProfile.adminUsername and adminPassword


		## Troubleshooting

		Windows support is still in active development with many changes each week. Read on for more info on known per-version issues and troubleshooting if you run into problems.


		#### Changing the OS disk size
		Click the [download](https://aka.ms/installazurecliwindows) link, and choose "Run". Click through the setup steps as needed.


		Affects: Azure CNI plugin <= 0.3.0
		Now, you can check the status of the pod and service with `.\kubectl.exe get pod` and `.\kubectl.exe get service` respectively.


		It will run 2 containers:

		- iis-container: This is a basic static web serber

		@@ -0,0 +1,335 @@
		# More on Windows and Kubernetes

		If you're trying to deploy Kubernetes with Windows the first time, be sure to check out the [quick start](windows.md) first. If you're looking for more details on deployments, examples or troubleshooting read on.


		## Customizing Windows deployments

		ACS-Engine allows a lot more customizations available in the [docs](../), but here are a few important ones you should know for Windows deployments. Each of these are extra parameters you can add into the ACS-Engine apimodel file (such as kubernetes-windows.json from the quick start) before running `acs-engine generate`


		### Choosing the Windows Server version

		If you want to deploy a specific Windows Server version, you can. First, find available versions with `az vm image list --publisher MicrosoftWindowsServer --all -o table`


		## Troubleshooting

		Windows support is still in active development with many changes each week. Read on for more info on known per-version issues and troubleshooting if you run into problems.


		#### Pods cannot ping default route or internet IPs

		Affects: All acs-engine deployed clusters

Docs - simplifying Windows walkthrough #3614

Docs - simplifying Windows walkthrough #3614

Conversation

PatrickLang commented Aug 4, 2018

PatrickLang commented Aug 4, 2018 • edited Loading

PatrickLang commented Aug 4, 2018 • edited Loading

codecov bot commented Aug 4, 2018 • edited Loading

Codecov Report

jsturtevant left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jldeen commented Aug 7, 2018 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jldeen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PatrickLang commented Aug 9, 2018

PatrickLang commented Aug 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mboersma left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jackfrancis commented Aug 15, 2018

PatrickLang commented Aug 4, 2018 •

edited

Loading

PatrickLang commented Aug 4, 2018 •

edited

Loading

codecov bot commented Aug 4, 2018 •

edited

Loading