This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
(docs): add available docker versions #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
docs/clusterdefinition.md
Outdated
| | imageReference.name | no | The name of a a Linux OS image. Needs to be used in conjunction with resourceGroup, below | | ||
| | imageReference.resourceGroup | no | Resource group that contains the Linux OS image. Needs to be used in conjunction with name, above | | ||
| | osType | no | Specifies the agent pool's Operating System. Supported values are `Windows` and `Linux`. Defaults to `Linux` | | ||
| | distro | no | Specifies the agent pool's Linux distribution. Supported values are `ubuntu` and `coreos` (CoreOS support is |
There was a problem hiding this comment.
the * put stuff in italic, I think you need to escape them...
|
/lgtm thanks @seanknox! |
|
(pending @CecileRobertMichon's note :) ) |
Codecov Report
@@ Coverage Diff @@
## master #3631 +/- ##
==========================================
- Coverage 55.77% 55.49% -0.28%
==========================================
Files 107 107
Lines 16238 16195 -43
==========================================
- Hits 9057 8988 -69
- Misses 6407 6433 +26
Partials 774 774 |
seanknox
force-pushed
the
docker-engine-docs
branch
from
c733f1c
to
e375a1e
Compare
|
@CecileRobertMichon made formatting changes, thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis, seanknox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: adds available docker versions to the cluster definition doc.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: