This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Fixing #3246 - Windows kubelet configs shouldn't overwrite Linux configs in hybrid cluster #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #3651 +/- ##
==========================================
+ Coverage 55.99% 56.04% +0.05%
==========================================
Files 108 108
Lines 16314 16318 +4
==========================================
+ Hits 9135 9146 +11
+ Misses 6412 6400 -12
- Partials 767 772 +5 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, PatrickLang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CecileRobertMichon
pushed a commit
to CecileRobertMichon/acs-engine
that referenced
this pull request
Aug 13, 2018
… configs in hybrid cluster (Azure#3651)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The previous code would apply Windows kubelet static configs over the Linux ones in a hybrid cluster. That would break the Linux nodes
Which issue this PR fixes:
fixes #3246