Golden image multiple k8s versions #3680
Conversation
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #3680 +/- ##
=======================================
Coverage 55.41% 55.41%
=======================================
Files 108 108
Lines 16098 16098
=======================================
Hits 8920 8920
Misses 6412 6412
Partials 766 766 |
CecileRobertMichon
changed the title
|
Running https://jenkins.azure-containers.io/view/acs-engine/job/k8s-deploy-linux-default-CSE-PR/ on this branch since 8/16 at 10:20am PST |
| @@ -121,7 +121,7 @@ function installContainerd() { | |||
| echo "Successfully installed cri-containerd..." | |||
| } | |||
|
|
|||
| function extractHyperkube() { | |||
| function pullHyperkube() { | |||
| TMP_DIR=$(mktemp -d) | |||
| retrycmd_if_failure 100 1 30 curl -sSL -o /usr/local/bin/img "https://acs-mirror.azureedge.net/img/img-linux-amd64-v0.4.6" | |||
There was a problem hiding this comment.
Should we have a separate func to get the img binary dependency?
There was a problem hiding this comment.
We could but it's only being used in this function for now so I would just be breaking the function down into two separate functions and always calling them one after the other. I also tried to limit the changes and since it was already in the same func I left it as is. If you think it's important I can do it, let me know.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: