Document orchestrator release and version #3711
Conversation
Added documentation for orchestratorRelease and orchestratorVersion
|
/assign @brendandburns |
|
/assign @CecileRobertMichon |
|
/unassign @brendandburns |
docs/clusterdefinition.md
Outdated
|
|
||
| Examples for valid values for the orchestrator release: `1.9`, `1.10`, `1.11`, etc. | ||
|
|
||
| Examples for valid values for the orchestrator version: `1.9.10`, `1.10.7`, `1.11.2`, etc. |
There was a problem hiding this comment.
this is only true for Kubernetes and supported versions could change overtime. Instead of listing a few hardcoded versions, how about pointing people to the orchestrators command which gives info on supported versions such as:
To learn more about supported orchestrators and versions, run the orchestrators command.
/bin/acs-engine orchestratorschanged examples to use `orchestrators` command
Codecov Report
@@ Coverage Diff @@
## master #3711 +/- ##
=========================================
+ Coverage 55.49% 55.5% +0.01%
=========================================
Files 108 108
Lines 16143 16143
=========================================
+ Hits 8958 8960 +2
+ Misses 6420 6419 -1
+ Partials 765 764 -1 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, idanlevin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
What this PR does / why we need it:
It updates the project documentation so people can learn how to use the project quicker
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #N/A
Special notes for your reviewer:
N/A
If applicable:
Release note:
Added documentation for orchestratorRelease and orchestratorVersion