enable pod priority for kubelet #3743
Conversation
ghost
assigned 
chengliangli0918
requested review from
mboersma,
jackfrancis,
nicolerenee and
CecileRobertMichon
| @@ -22,6 +22,7 @@ ExecStart=/usr/local/bin/kubelet \ | |||
| --node-labels="${KUBELET_NODE_LABELS}" \ | |||
| --v=2 \ | |||
| --volume-plugin-dir=/etc/kubernetes/volumeplugins \ | |||
| --feature-gates=PodPriority=true \ | |||
There was a problem hiding this comment.
There is already a --feature-gates flag defined in $KUBELET_CONFIG, https://github.com/Azure/acs-engine/blob/master/pkg/acsengine/defaults-kubelet.go would be the right place to change it (look for the addDefaultFeatureGates function
Codecov Report
@@ Coverage Diff @@
## master #3743 +/- ##
==========================================
- Coverage 55.49% 55.48% -0.01%
==========================================
Files 108 108
Lines 16139 16140 +1
==========================================
- Hits 8956 8955 -1
- Misses 6419 6420 +1
- Partials 764 765 +1 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, chengliangli0918, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
done |
https://v1-10.docs.kubernetes.io/docs/concepts/configuration/pod-priority-preemption/#how-to-use-priority-and-preemption
"
Pod priority and preemption is disabled by default in Kubernetes 1.8. To enable the feature, set this command-line flag for the API server, scheduler and kubelet:
--feature-gates=PodPriority=true
"
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: