Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Add build metadata to VHD #3764

Merged
merged 7 commits into from
Aug 31, 2018
Merged

Add build metadata to VHD #3764

merged 7 commits into from
Aug 31, 2018

Conversation

CecileRobertMichon
Copy link
Contributor

What this PR does / why we need it: Add info for debugging custom images, including commit ID, build ID and build number.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@ghost ghost added in progress and removed approved labels Aug 29, 2018
@acs-bot acs-bot added the size/S label Aug 29, 2018
@@ -3,6 +3,10 @@
source /home/packer/provision_installs.sh
source /home/packer/provision_source.sh

echo "\nVSTS Build NUMBER: ${1}" >> /var/log/azure/golden-image-install.complete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make these named env variables instead of ordinal arguments?

@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

Merging #3764 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3764      +/-   ##
==========================================
- Coverage   55.49%   55.49%   -0.01%     
==========================================
  Files         108      108              
  Lines       16143    16140       -3     
==========================================
- Hits         8959     8957       -2     
+ Misses       6420     6418       -2     
- Partials      764      765       +1

@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Aug 31, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit accda8a into master Aug 31, 2018
@ghost ghost removed the in progress label Aug 31, 2018
@jackfrancis jackfrancis deleted the metadata-vhd branch August 31, 2018 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants