This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Sync up health monitoring #3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## master #3817 +/- ##
=========================================
Coverage ? 55.67%
=========================================
Files ? 109
Lines ? 16246
Branches ? 0
=========================================
Hits ? 9045
Misses ? 6411
Partials ? 790 |
|
New changes are detected. LGTM label has been removed. |
|
/lgtm pending E2E |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enables kubelet monitoring and restarting with Kubernetes'Syncs up the acs-engine implementation with that being used on AKS infrastructure.health-monitor.shscript.We saw some CSE 30 (Kubernetes can't start) errors in CI for this PR, so let's disable the kubelet-monitor again and leave the other changes intact while we do more testing.
cc: @juan-lee @jwilder
Special notes for your reviewer:
I tested this with a new acs-engine cluster to make sure units landed in the right places and everything starts up correctly.
If applicable:
Release note: