This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Removing code duplication in addon logic #3832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
tariq1890
force-pushed
the
addon_enabled_cleanup
branch
from
185f639
to
7b0fa21
Compare
jackfrancis
reviewed
Sep 12, 2018
jackfrancis
reviewed
Sep 12, 2018
tariq1890
changed the title
|
Thanks for doing this @tariq1890! ❤️ |
tariq1890
force-pushed
the
addon_enabled_cleanup
branch
from
7b0fa21
to
6e33ec8
Compare
tariq1890
force-pushed
the
addon_enabled_cleanup
branch
from
6e33ec8
to
accc944
Compare
tariq1890
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3832 +/- ##
=========================================
+ Coverage 55.69% 55.7% +<.01%
=========================================
Files 109 109
Lines 16249 16207 -42
=========================================
- Hits 9050 9028 -22
+ Misses 6411 6386 -25
- Partials 788 793 +5 |
mboersma
approved these changes
Sep 12, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.