This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
update keyvault-flexvol image and default to enabled #3841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ritazh
force-pushed
the
kvflexvoladdon
branch
2 times, most recently
from
c0b91ce
to
08c95cf
Compare
tariq1890
reviewed
Sep 13, 2018
pkg/api/vlabs/validate_test.go
Outdated
| @@ -284,7 +284,7 @@ func Test_OrchestratorProfile_Validate(t *testing.T) { | |||
|
|
|||
| for testName, test := range tests { | |||
| t.Run(testName, func(t *testing.T) { | |||
| t.Parallel() | |||
| //t.Parallel() | |||
There was a problem hiding this comment.
Is this required? I tested this test case change and it seems to work consistently with t.Parallel() enabled.
|
Looks good to me save for that one review comment. @jackfrancis This would need to be merged before #3840 is merged. |
ritazh
force-pushed
the
kvflexvoladdon
branch
from
08c95cf
to
d45829c
Compare
|
/lgtm |
tariq1890
approved these changes
Sep 13, 2018
|
/lgtm pending E2E |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, ritazh, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #3841 +/- ##
==========================================
+ Coverage 55.65% 56.06% +0.41%
==========================================
Files 109 109
Lines 16207 16207
==========================================
+ Hits 9020 9087 +67
+ Misses 6400 6334 -66
+ Partials 787 786 -1 |
mboersma
pushed a commit
to mboersma/acs-engine
that referenced
this pull request
Sep 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.