Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

add retry to nvidia drivers install #3862

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

jackfrancis
Copy link
Member

What this PR does / why we need it: Retry nvidia drivers installation as we've observed this failing and then succeeding on subsequent attempts

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #3839

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

add retry to nvidia drivers install

@ghost ghost assigned jackfrancis Sep 17, 2018
@ghost ghost added the in progress label Sep 17, 2018
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Sep 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 81ee734 into Azure:master Sep 17, 2018
@ghost ghost removed the in progress label Sep 17, 2018
@jackfrancis jackfrancis deleted the nvidia-retry-drivers-install branch September 17, 2018 23:40
jackfrancis added a commit that referenced this pull request Sep 17, 2018
@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #3862 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3862      +/-   ##
==========================================
- Coverage   56.36%   56.34%   -0.02%     
==========================================
  Files         109      109              
  Lines       16458    16458              
==========================================
- Hits         9277     9274       -3     
- Misses       6372     6376       +4     
+ Partials      809      808       -1

mboersma pushed a commit to mboersma/acs-engine that referenced this pull request Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvidia drivers fail start on 1.9 clusters w/ AKS 0.13.0 VHD
3 participants