Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument ADX Mon components with more metrics #101

Closed
wants to merge 8 commits into from
Closed

Instrument ADX Mon components with more metrics #101

wants to merge 8 commits into from

Conversation

steeling
Copy link

This PR implements the following:

  • Standard set of HTTP metrics for all servers and http clients.
  • Custom metrics on all internal errors that were previously logged, but not recorded.
  • Add error counters, instead of a healthy error "guage", as the gauge can flip-flop between healthy and unhealthy states, and a metric scraper would only see the current state. That is we could fail 50% of the time, but appear healthy.
  • Add more stats around file uploads, particularly around size, age, owner, and the reason they were uploaded.
  • Modify a couple methods as needed to be more DRY

@steeling
Copy link
Author

cc: @jwilder

@steeling steeling force-pushed the feature/more-metrics branch 2 times, most recently from 5c86c75 to ecdd59a Compare August 29, 2023 02:16
@steeling steeling changed the title Feature/more metrics Instrument ADX Mon components with more metrics Aug 29, 2023
jwilder
jwilder requested changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@jwilder jwilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Mainly some concerns about metric naming and the usability of them.

metrics/metrics.go Show resolved Hide resolved
metrics/metrics.go Outdated Show resolved Hide resolved
metrics/metrics.go Outdated Show resolved Hide resolved
metrics/metrics.go Outdated Show resolved Hide resolved
metrics/middleware.go Outdated Show resolved Hide resolved
metrics/middleware.go Outdated Show resolved Hide resolved
metrics/metrics.go Outdated Show resolved Hide resolved
metrics/middleware.go Outdated Show resolved Hide resolved
metrics/metrics.go Outdated Show resolved Hide resolved
metrics/metrics.go Outdated Show resolved Hide resolved
@steeling steeling requested a review from jwilder August 30, 2023 00:06
@steeling steeling force-pushed the feature/more-metrics branch 3 times, most recently from 0609d1e to cccdfbe Compare September 6, 2023 20:17
@jwilder jwilder self-requested a review September 6, 2023 20:43
@jwilder
Copy link
Collaborator

jwilder commented Sep 6, 2023

Build failed

Error: ingestor/otlp/logs.go:34:18: undefined: metrics.RequestsReceived

@steeling
Copy link
Author

steeling commented Sep 6, 2023

Build failed

Error: ingestor/otlp/logs.go:34:18: undefined: metrics.RequestsReceived

fixed errors from rebasing

@steeling
Copy link
Author

@jwilder are we good to submit this? It's collecting quite a bit of conflicts and takes a bit of work to keep up to date

@jwilder
Copy link
Collaborator

jwilder commented Sep 12, 2023

Yes. The required checks are not completing though. Not sure how to get them to run.

@jwilder jwilder closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilder jwilder jwilder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steeling @jwilder