Expose a Reader for TLV metadata #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a benchmark for this so we can easily profile it? |
jwilder
requested changes
Aug 18, 2023
jessejlt
force-pushed
the
jesse/tlv-reader
branch
from
0056215
to
2c1e0b3
Compare
jwilder
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extracting TLV metadata from our WAL segments, we need to be mindful that the checksum is calculated against the entire segment, including any potential TLV metadata; however, when reading one of these TLV-encoded Segments, we need to provide a way to expose the TLV while also removing it from the underlying byte-stream when read. By exposing a TLV io.Reader, we can wrap our Segment reader in such a way that TLV can still be extracted, checksums apply to the TLV, but callers, like Kusto::Ingest, do not have TLV bytes when they read the segment.