Ingestion performance tuning #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytes.ToLower allocates a slice and since this func is in the hot path for write, it creates a lot of garbage. This switches to a case-insensitive sort func that does not allocate.
This converts the marshalTS func to not allocate during marhsalling which doubles the throughput and removes excess memory allocated that needs to be garbage collected. benchmark old ns/op new ns/op delta BenchmarkMarshalCSV-10 2117 1141 -46.10% benchmark old allocs new allocs delta BenchmarkMarshalCSV-10 20 0 -100.00% benchmark old bytes new bytes delta BenchmarkMarshalCSV-10 1548 0 -100.00%
Bettter conveys that this is a one-time operation.
This sacrifices a little bit of disk for faster compression time and lower CPU util.
The rings account for a lot of allocations and heap space. Re-using them cuts memory usage and GC work for the runtime.
These were too low for larger number of clients and cause new ones to be allocated frequently.
jessejlt
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commit removes the majority of allocations from the write path which reduces GC overhead, CPU and memory utilization by 2x-3x.
The optimizations are pretty straight-forward: