Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Commit

Permalink
feat: add "coming soon" regions to allow list (#5107)
Browse files Browse the repository at this point in the history
  • Loading branch information
mboersma authored Aug 24, 2023
1 parent 3537327 commit 7b61192
Show file tree
Hide file tree
Showing 3 changed files with 57 additions and 0 deletions.
28 changes: 28 additions & 0 deletions cmd/get_locations.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ var (
germanyCentralName = "germanycentral"
germanyNortheastDisplayName = "Germany Northeast"
germanyNortheastName = "germanynortheast"
israelCentralDisplayName = "Israel Central"
israelCentralName = "israelcentral"
italyNorthDisplayName = "Italy North"
italyNorthName = "italynorth"
spainCentralDisplayName = "Spain Central"
spainCentralName = "spaincentral"
usDodCentralDisplayName = "US DoD Central"
usDodCentralName = "usdodcentral"
usDodEastDisplayName = "US Dod East"
Expand Down Expand Up @@ -247,6 +253,28 @@ func (glc *LocationsCmd) run(cmd *cobra.Command, args []string) error {
Latitude: &notAvailable,
Longitude: &notAvailable,
},
// Coming soon regions
{
ID: &notAvailable,
Name: &israelCentralName,
DisplayName: &israelCentralDisplayName,
Latitude: &notAvailable,
Longitude: &notAvailable,
},
{
ID: &notAvailable,
Name: &italyNorthName,
DisplayName: &italyNorthDisplayName,
Latitude: &notAvailable,
Longitude: &notAvailable,
},
{
ID: &notAvailable,
Name: &spainCentralName,
DisplayName: &spainCentralDisplayName,
Latitude: &notAvailable,
Longitude: &notAvailable,
},
}
// Add special locations if they aren't already in the list
for _, s := range specialLocations {
Expand Down
24 changes: 24 additions & 0 deletions cmd/get_locations_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,9 @@ func ExampleLocationsCmd_run_humanOutput() {
// eastus2euap East US 2 EUAP (Canary) N/A N/A
// germanycentral Germany Central N/A N/A
// germanynortheast Germany Northeast N/A N/A
// israelcentral Israel Central N/A N/A
// italynorth Italy North N/A N/A
// spaincentral Spain Central N/A N/A
// usdodcentral US DoD Central N/A N/A
// usdodeast US Dod East N/A N/A
// usgovarizona US Gov Arizona N/A N/A
Expand Down Expand Up @@ -221,6 +224,27 @@ func ExampleLocationsCmd_run_jsonOutput() {
// },
// {
// "id": "N/A",
// "name": "israelcentral",
// "displayName": "Israel Central",
// "latitude": "N/A",
// "longitude": "N/A"
// },
// {
// "id": "N/A",
// "name": "italynorth",
// "displayName": "Italy North",
// "latitude": "N/A",
// "longitude": "N/A"
// },
// {
// "id": "N/A",
// "name": "spaincentral",
// "displayName": "Spain Central",
// "latitude": "N/A",
// "longitude": "N/A"
// },
// {
// "id": "N/A",
// "name": "usdodcentral",
// "displayName": "US DoD Central",
// "latitude": "N/A",
Expand Down
5 changes: 5 additions & 0 deletions pkg/helpers/azure_locations.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7b61192

Please sign in to comment.