-
Notifications
You must be signed in to change notification settings - Fork 519
chore: Install Windows Server 2019 10C updates in Windows VHD #3956
Conversation
37e63f0
to
b9d7c3a
Compare
@daschott We are seeing consistent failures in our service to service tests for August optional patch (10.0.17763.1554): https://dev.azure.com/AzureContainerUpstream/Kubernetes/_build/results?buildId=13542&view=logs&j=49d03c1b-89df-5eb4-98f6-9a6bbfef7d4e&t=aa477d3b-e842-5070-3943-3b7afd505a42&l=2954 If I run the test by itself as in We have been running this test for a couple years and this test passes regularly in our other e2e tests on August patches (10.0.17763.1397). Are you getting any reports or know of any issues? What are next steps to debug this? @AbelHu fyi |
Was able to reproduce on local deployment and grab logs. Connectivity via IP addresses are ok. CNI configuration looks ok as well. I am seeing hns Loadbalancers programed with the DNS entry. But the following is in kubeproxy:
The ports don't look exhausted:
From within a pod:
Going directly to the DNS pod works for the api server:
|
b9d7c3a
to
5dd8787
Compare
Codecov Report
@@ Coverage Diff @@
## master #3956 +/- ##
=======================================
Coverage 73.69% 73.69%
=======================================
Files 147 147
Lines 23164 23164
=======================================
Hits 17070 17070
Misses 4979 4979
Partials 1115 1115 Continue to review full report at Codecov.
|
aa51d99
to
e9c55de
Compare
e9c55de
to
3c019dc
Compare
in 10.0.17763.1397 (August) the following works:
In 10.0.17763.1554 (October) if the network doesn't exist you can't delete the vfp policies if network was removed first:
To unblock this, I have re-ordered calls |
@@ -49,6 +49,11 @@ if ($global:EnableHostsConfigAgent) { | |||
# Perform cleanup | |||
# | |||
|
|||
Write-Log "Cleaning up persisted HNS policy lists" | |||
# Workaround for https://github.com/kubernetes/kubernetes/pull/68923 in < 1.14, | |||
# and https://github.com/kubernetes/kubernetes/pull/78612 for <= 1.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this "workaround" is still lets update the comments again to point the behavior you found in kube-proxy.
Changes look good to me. |
Looks like it still failed. These steps work when I manually ran them. Looking into it |
I was able to get this to pass with the changes in #4002. Once that merges I will rebase these changes |
0d73ca8
to
7db4ce0
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FYI @AbelHu |
Reason for Change:
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: