fix: Re-ordering HNS policy removal due to 10c change in behavior and consolidating logic in Windows cleanup scripts

[jsturtevant]

Reason for Change:

First step in refactoring shared logic in startup and windows node reset. We learned in 10c update (#3956) adds a breaking change that requires Get-HnsPolicyList | Remove-HnsPolicyList to be removed before HNS-Network. We also need turn off kubeproxy while doing this.

This also adds removed containerd images during the kubelet startup.

We should be able to have a follow up with a change that shares logic between startup and windowsnodereset. This needs a little more consideration so is not included here.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

• No
• Yes

If "Yes," did you notify that project's maintainers and provide attribution?

• No
• Yes

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Notes:
Requires signed scripts before kicking off tests
/hold

[codecov]

Codecov Report

Merging #4002 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4002   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         147      147           
  Lines       23164    23164           
=======================================
  Hits        17070    17070           
  Misses       4979     4979           
  Partials     1115     1115           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d36d436...475822a. Read the comment docs.

[marosset]

Should we remove these two workaround comments or say that the October patch impact ALL versions to make sure this doesn't get accidently cleaned up in the future?

[marosset]

@jsturtevant should we figure out a way to have kubeletstart.ps1 call into a portion of the windowsnodereset script so the contents will not drift again?

I'm thinking maybe add a -CleanupOnly flag to windowsnodereset.ps1 that just stops services and performs the cleanup.
kubeletstart.ps1 can call windowsnodereset.ps1 -CleanupOnly then start kubelet.exe

Either that or create a cleanup script that both of these existing scripts calls.

[jsturtevant]

Adding a -CleanupOnly flag to windowsnodereset.ps1 should work. I initially didn't do this because I wanted to keep the refactor small. I will give this a go since the I've already factored out the function

[jsturtevant]

added -CleanupOnly flag, Running tests against new scripts now will report back

[jsturtevant]

After testing, the approach of using -CleanupOnly didn't work well because of two things:

• log file contention between different processes
• NodeReset starts/stops several services including kubelet. If we are in the startup of kubelet then we shouldn't stop our selves.

[jsturtevant]

I've updated to use a common file that only cleans up the network and other files. It is up to the caller to turn off the services required.

[jsturtevant]

These changes passed a local test run on 1.19 on a 10c image

Ran 45 of 64 Specs in 3187.352 seconds
SUCCESS! -- 45 Passed | 0 Failed | 0 Pending | 19 Skipped
PASS

[marosset]

/lgtm

[marosset]

/lgtm

[marosset]

Whoo -

[marosset]

/lgtm

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment