Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: fixing an issue where windows cannot start kubelet to get podCID… #4039

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Nov 17, 2020

…R on Windows nodes when using kubenet

Fixes a regression introduced by #4002 where kubelet cannot start one windows nodes when using kubenet.

Reason for Change:

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@marosset
Copy link
Contributor Author

/cc @jsturtevant @jackfrancis

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #4039 (f066bf3) into master (f5bdb8b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4039   +/-   ##
=======================================
  Coverage   73.06%   73.06%           
=======================================
  Files         145      145           
  Lines       21856    21856           
=======================================
  Hits        15969    15969           
  Misses       4849     4849           
  Partials     1038     1038           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bdb8b...f066bf3. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Nov 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsturtevant jsturtevant merged commit 8e6c8f5 into Azure:master Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants