Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: ensure hostPort routing #4186

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

Inspired by this AKS issue report, this PR brings a new E2E test that validates basic hostPort functionality:

Azure/AKS#2070

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Jan 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spec:
restartPolicy: Never
containers:
- image: curlimages/curl
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jchauncey @sozercan do we have a local (MCR/ACR) image that we can use for this curl test, so that we can be better internet citizens?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have mcr.microsoft.com/oss/tutum/curl:latest in MCR but it's pretty old

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a better alternative than pounding dockerhub, thanks!

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #4186 (f1215a9) into master (ad20028) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4186      +/-   ##
==========================================
+ Coverage   73.27%   73.38%   +0.10%     
==========================================
  Files         135      135              
  Lines       20720    20804      +84     
==========================================
+ Hits        15183    15267      +84     
  Misses       4562     4562              
  Partials      975      975              
Impacted Files Coverage Δ
pkg/api/k8s_versions.go 100.00% <0.00%> (ø)
pkg/api/common/versions.go 96.37% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b3b57...f1215a9. Read the comment docs.

@jackfrancis jackfrancis merged commit ae4bb40 into Azure:master Jan 25, 2021
@jackfrancis jackfrancis deleted the test-hostport branch January 25, 2021 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants