-
Notifications
You must be signed in to change notification settings - Fork 522
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spec: | ||
restartPolicy: Never | ||
containers: | ||
- image: curlimages/curl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jchauncey @sozercan do we have a local (MCR/ACR) image that we can use for this curl test, so that we can be better internet citizens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have mcr.microsoft.com/oss/tutum/curl:latest
in MCR but it's pretty old
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a better alternative than pounding dockerhub, thanks!
Codecov Report
@@ Coverage Diff @@
## master #4186 +/- ##
==========================================
+ Coverage 73.27% 73.38% +0.10%
==========================================
Files 135 135
Lines 20720 20804 +84
==========================================
+ Hits 15183 15267 +84
Misses 4562 4562
Partials 975 975
Continue to review full report at Codecov.
|
Reason for Change:
Inspired by this AKS issue report, this PR brings a new E2E test that validates basic hostPort functionality:
Azure/AKS#2070
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: