Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

make cluster autoscaler scan interval configurable #145

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

tariq1890
Copy link
Contributor

Fixes #116

@acs-bot
Copy link

acs-bot commented Dec 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis
Copy link
Member

/lgtm, thanks @tariq1890! Let's add some documentation to the README under examples/addons/cluster-autoscaler/

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #145 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   53.09%   53.07%   -0.03%     
==========================================
  Files          95       95              
  Lines       14199    14200       +1     
==========================================
- Hits         7539     7536       -3     
- Misses       5989     5993       +4     
  Partials      671      671

@tariq1890
Copy link
Contributor Author

Thanks for the review! Docs updated

@jackfrancis jackfrancis merged commit 341e832 into Azure:master Dec 14, 2018
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants