fix: Wait for management IP after creating ext network.

[pradipd]

Reason for Change:

Fixes a connectivity issue we see intermittently in AKS. After the external network is created, it may take "some time" for the network adapter to get an IP address. It will have a 169.254.0.0 address. It is best to wait for the network adapter to get a proper IP address before continuing.
In the repro we looked at, HNS used the 169.254 address for many VFP rules. This means we created containers before the network adapter got its proper ip address.

Issue Fixed:

Fixes ICM 147788786. I do not think we have a public GitHub issue on this.

Requirements:

• [X ] uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Notes:

[welcome]

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

[pradipd]

@PatrickLang @marosset FYI.

[pradipd]

/assign @PatrickLang @marosset @madhanrm

[daschott]

@jackfrancis FYI

[daschott]

FYI This PR contains an important fix. Without this change, all users using AKS-Engine with Window nodes are at risk of networking being plumbed incorrectly. We have customers in production that rely on this fix getting in. We have validated this change as well.

[marosset]

/azp run pr-e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[codecov]

Codecov Report

Merging #2049 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2049      +/-   ##
==========================================
- Coverage   76.67%   76.55%   -0.13%     
==========================================
  Files         135      135              
  Lines       20564    20709     +145     
==========================================
+ Hits        15768    15854      +86     
- Misses       3877     3931      +54     
- Partials      919      924       +5

[daschott]

@marosset @PatrickLang friendly ping :) This seems to be passing all the tests and was validated by Pradip as well. Are there any concerns or is there any additional work that you would like to see so this can be merged? Thanks!

[marosset]

@daschott I left a comment about adding some additional logging here.
Can that get added in please?

[marosset]

/lgtm

thanks

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, pradipd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[daschott]

@marosset Thanks for the LGTM! Do you know how long it takes for these checks to complete so this can be merged?

[marosset]

/azp run pr-e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[marosset]

Sorry, i forgot to trigger the e2e tests again after the changes.
The PR should merge automatically after those complete.

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉