fix: Fix some path handling in collect-windows-logs script

[PatrickLang]

Reason for Change:

The previous method I used to create an array of files would sometimes end up creating a two-dimensional array. Allocating it separately as an empty array and always using += avoids this and is easier to read

[PatrickLang]

/assign @marosset

[codecov]

Codecov Report

Merging #2488 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2488   +/-   ##
======================================
  Coverage    72.7%   72.7%           
======================================
  Files         130     130           
  Lines       24105   24105           
======================================
  Hits        17526   17526           
  Misses       5553    5553           
  Partials     1026    1026

[marosset]

/lgtm

[marosset]

I'm testing this out on some of my clusters i have up.

[marosset]

Do you want to add azure-vnet-ipam.log here?

[PatrickLang]

sure why not. I haven't seen it fail on that file but if azure-vnet.log can be locked this one probably can too.

[PatrickLang]

interesting - I don't have a c:\k\azure-vnet-ipam.log

[PatrickLang]

just azure-vnet-ipam.json - is that what you meant?

[PatrickLang]

I took azure-vnet-ipam.log back out and rebased to keep the history clean

[marosset]

strange

[marosset]

It might be a good idea to add a log statement here like "Fetching ETW events, this may take a while..." because this takes a while and the first time I rant he script I thought it hung copying files.

[PatrickLang]

sure

[PatrickLang]

ok new output:

.\collect-windows-logs.ps1


    Directory: C:\Users\azureuser\AppData\Local\Temp


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----       12/21/2019  12:16 AM                nz3m4hge.ctn
Copying kubelet.err.log to temp
Copying kubelet.log to temp
Copying kubeproxy.log to temp
Copying kubeproxy.err.log to temp
Copying containerd.err.log to temp
Copying containerd.log to temp
Copying azure-vnet-telemetry.log to temp
Copying azure-vnet.log to temp
Exporting ETW events to CSV files
WARNING: The names of some imported commands from the module 'helper' include unapproved verbs that might make them less
discoverable. To find the commands with unapproved verbs, run the Import-Module command again with the Verbose parameter. For a list  of approved verbs, type Get-Verb.
File c:\k\debug\dumpVfpPolicies.ps1 already exists.
File c:\k\debug\hns.psm1 already exists.
File c:\k\debug\starthnstrace.cmd already exists.
File c:\k\debug\startpacketcapture.cmd already exists.
File c:\k\debug\stoppacketcapture.cmd already exists.
File c:\k\debug\portReservationTest.ps1 already exists.
WARNING: The names of some imported commands from the module 'hns' include unapproved verbs that might make them less discoverable.   To find the commands with unapproved verbs, run the Import-Module command again with the Verbose parameter. For a list of approved    verbs, type Get-Verb.
C:\k\debug\tj5otk5h.5uh
WARNING: The names of some imported commands from the module 'helper' include unapproved verbs that might make them less
discoverable. To find the commands with unapproved verbs, run the Import-Module command again with the Verbose parameter. For a list  of approved verbs, type Get-Verb.
File c:\k\debug\VFP.psm1 already exists.
Logs are available at C:\k\debug\tj5otk5h.5uh
Compressing all logs to 2758k8s010-20191221-121625_logs.zip



FullName                                                                     Length
--------                                                                     ------
C:\k\azure-vnet-telemetry.log.1                                             5252718
C:\k\azure-vnet-telemetry.log.2                                             5247427
C:\k\azure-vnet-telemetry.log.3                                             5245465
C:\k\azure-vnet-telemetry.log.4                                             5248190
C:\k\azure-vnet-telemetry.log.5                                             5243766
C:\k\azure-vnet-telemetry.log.6                                             5245985
C:\k\azure-vnet-telemetry.log.7                                             5245989
C:\k\azure-vnet.log.1                                                       5243524
C:\k\azure-vnet.log.2                                                       5243613
C:\k\azure-vnet.log.3                                                       5243571
C:\k\azure-vnet.log.4                                                       5242931
C:\k\azure-vnet.log.5                                                       5243187
C:\k\azure-vnet.log.6                                                       5245861
C:\k\azure-vnet.log.7                                                       5243308
C:\k\kubelet.err-20191211T032141.867.log                                    1048609
C:\k\kubelet.err-20191211T081458.750.log                                    1048447
C:\k\kubelet.err-20191211T130814.621.log                                    1048342
C:\k\kubelet.err-20191211T180129.501.log                                    1048300
C:\k\kubelet.err-20191212T011812.436.log                                    1048585
C:\k\kubelet.err-20191212T075412.704.log                                    1048357
C:\k\kubelet.err-20191212T144517.626.log                                    1048505
C:\k\kubelet.err-20191212T195233.336.log                                    1048715
C:\k\kubelet.err-20191212T223313.374.log                                    1048088
C:\k\kubelet.err-20191212T223313.375.log                                        107
C:\k\kubelet.err-20191212T223313.391.log                                        451
C:\k\kubelet.err-20191219T205751.077.log                                    1048601
C:\k\kubelet.err-20191219T225931.084.log                                    1047781
C:\k\kubelet.err-20191219T225931.086.log                                        107
C:\k\kubelet.err-20191219T225931.101.log                                        279
C:\k\kubelet.err-20191220T010050.419.log                                    1048191
C:\k\kubelet.err-20191220T010050.420.log                                        102
C:\k\kubelet.err-20191220T010050.435.log                                        322
C:\k\kubeproxy-20191215T101807.586.log                                      1048612
C:\k\kubeproxy-20191217T230149.480.log                                      1048608
C:\k\kubeproxy.err-20191212T060357.408.log                                  1048632
C:\k\kubeproxy.err-20191218T160308.890.log                                  1048654
C:\k\kubeproxy.err-20191220T181856.436.log                                  1048612
C:\k\windowsnodereset.log                                                      1800
C:\Users\azureuser\AppData\Local\Temp\nz3m4hge.ctn\kubelet.err.log           584131
C:\Users\azureuser\AppData\Local\Temp\nz3m4hge.ctn\kubelet.log                 4729
C:\Users\azureuser\AppData\Local\Temp\nz3m4hge.ctn\kubeproxy.log             355635
C:\Users\azureuser\AppData\Local\Temp\nz3m4hge.ctn\kubeproxy.err.log         192080
C:\Users\azureuser\AppData\Local\Temp\nz3m4hge.ctn\azure-vnet-telemetry.log 1093156
C:\Users\azureuser\AppData\Local\Temp\nz3m4hge.ctn\azure-vnet.log            211162
C:\Users\azureuser\AppData\Local\Temp\\20191221-121625_services.csv
C:\Users\azureuser\AppData\Local\Temp\\20191221-121625_hyper-v-compute-operational.csv
C:\Users\azureuser\AppData\Local\Temp\\20191221-121625_docker.csv
C:\Users\azureuser\AppData\Local\Temp\\20191221-121625_pagefile.txt
C:\k\debug\tj5otk5h.5uh\arp.txt
C:\k\debug\tj5otk5h.5uh\docker.txt
C:\k\debug\tj5otk5h.5uh\dynamicportrange.txt
C:\k\debug\tj5otk5h.5uh\endpoint.txt
C:\k\debug\tj5otk5h.5uh\Ethernet 2_int.txt
C:\k\debug\tj5otk5h.5uh\excludedportrange.txt
C:\k\debug\tj5otk5h.5uh\hcsdiag.txt
C:\k\debug\tj5otk5h.5uh\hnsdiag.txt
C:\k\debug\tj5otk5h.5uh\ip.txt
C:\k\debug\tj5otk5h.5uh\mtu.txt
C:\k\debug\tj5otk5h.5uh\network.txt
C:\k\debug\tj5otk5h.5uh\networkdetailed.txt
C:\k\debug\tj5otk5h.5uh\nmscrub.txt
C:\k\debug\tj5otk5h.5uh\nvspinfo.txt
C:\k\debug\tj5otk5h.5uh\policy.txt
C:\k\debug\tj5otk5h.5uh\ports.txt
C:\k\debug\tj5otk5h.5uh\reservedports.txt
C:\k\debug\tj5otk5h.5uh\routes.txt
C:\k\debug\tj5otk5h.5uh\tcpconnections.txt
C:\k\debug\tj5otk5h.5uh\vEthernet (Ethernet 2)_int.txt
C:\k\debug\tj5otk5h.5uh\vEthernet (nat)_int.txt
C:\k\debug\tj5otk5h.5uh\vfpOutput.txt
C:\k\debug\tj5otk5h.5uh\vswitchForwarding.txt
C:\k\debug\tj5otk5h.5uh\winver.txt




    Directory: C:\Users\azureuser


Mode          LastWriteTime  Length Name
----          -------------  ------ ----
-a---- 12/21/2019  12:16 AM 3258444 2758k8s010-20191221-121625_logs.zip

[marosset]

/lgtm

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, PatrickLang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [PatrickLang,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment