This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
test: enable configurable LoadBalancer test timeout #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2700 +/- ##
=======================================
Coverage 71.93% 71.93%
=======================================
Files 134 134
Lines 25097 25097
=======================================
Hits 18053 18053
Misses 5988 5988
Partials 1056 1056 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR enables configurable test timeouts for LoadBalancer reconciliation, to (1) ensure that cluster configurations requiring more reconciliation time are able to be configured appropriately for test validation, and (2) to decrease the timeout for cluster configurations that we expect to have more responsive LB reconciliations.
Issue Fixed:
Requirements:
Notes: