Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: restart hns for Windows dual-stack #4281

Closed
wants to merge 1 commit into from

Conversation

vavenk-ms
Copy link
Contributor

Reason for Change:

Due to a bug in the hns service there is a race where it picks up the incorrect IPv6 address from the node in some cases. The hns service has to be restarted after the node internal IPv6 address is available when dual-stack is enabled.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Feb 18, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vavenk-ms
To complete the pull request process, please assign ritazh
You can assign the PR to them by writing /assign @ritazh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #4281 (3291afd) into master (b9c9dda) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4281   +/-   ##
=======================================
  Coverage   72.06%   72.06%           
=======================================
  Files         141      141           
  Lines       21686    21686           
=======================================
  Hits        15628    15628           
  Misses       5107     5107           
  Partials      951      951           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c9dda...3291afd. Read the comment docs.

@jsturtevant
Copy link
Contributor

should this be a commit as part of #4176?

@vavenk-ms
Copy link
Contributor Author

should this be a commit as part of #4176?

@jsturtevant sure, I can add it there and close this one.

@vavenk-ms
Copy link
Contributor Author

Added the commit to #4176

@vavenk-ms vavenk-ms closed this Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants