feat: add support for Kubernetes 1.11.9 #873
Conversation
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
| @@ -119,13 +119,13 @@ func TestK8sVars(t *testing.T) { | |||
| "mountetcdScript": GetKubernetesB64Mountetcd(), | |||
| "nsgID": "[resourceId('Microsoft.Network/networkSecurityGroups',variables('nsgName'))]", | |||
| "nsgName": "[concat(variables('masterVMNamePrefix'), 'nsg')]", | |||
| "orchestratorNameVersionTag": "Kubernetes:1.11.8", | |||
| "orchestratorNameVersionTag": "Kubernetes:1.11.9", | |||
There was a problem hiding this comment.
are we going to have to update these tests every time there's a new default k8s version patch? Is there any way we can make them expect the latest patch instead of hardcoding to a specific patch?
There was a problem hiding this comment.
I'm sure there is a way. I'll enter a ticket to refactor these tests so we're not chasing 1.11.x patches.
Edit: see #878
mboersma
force-pushed
the
add-k8s-1.11.9
branch
from
ea7e0fc
to
61f480f
Compare
mboersma
force-pushed
the
add-k8s-1.11.9
branch
from
61f480f
to
cd395a3
Compare
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #873 +/- ##
=======================================
Coverage 68.29% 68.29%
=======================================
Files 115 115
Lines 16938 16938
=======================================
Hits 11567 11567
Misses 4613 4613
Partials 758 758 |
Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.11.md#v1119
Issue Fixed:
Requirements:
Notes: