Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specified resource types and names for kube-objects collector #188

Merged
merged 4 commits into from
Jul 6, 2022

Conversation

peterbom
Copy link
Contributor

@peterbom peterbom commented Jul 4, 2022

Addresses #187

As well as using the resource type from the <namespace>/<resource-type> values in the DIAGNOSTIC_KUBEOBJECTS_LIST environment variable, this also allows specifying individual resources with an extra /, e.g. <namespace>/<resource-type>/<resource-name> (because the az CLI examples claim that behaviour).

This also adds a number of automated tests to cover the behaviour being fixed.

@peterbom peterbom requested a review from Tatsinnit July 4, 2022 05:21
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #188 (122b6b9) into master (9030f55) will increase coverage by 0.63%.
The diff coverage is 84.09%.

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   78.82%   79.45%   +0.63%     
==========================================
  Files          13       13              
  Lines         713      740      +27     
==========================================
+ Hits          562      588      +26     
- Misses         92       93       +1     
  Partials       59       59              
Impacted Files Coverage Δ
pkg/collector/kubeobjects_collector.go 88.13% <84.09%> (+6.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9030f55...122b6b9. Read the comment docs.

@Tatsinnit Tatsinnit added enhancement 🏎 New feature or request bugfix 🧑‍🔧 Implementation which intend to fix a behaviour. labels Jul 5, 2022
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@peterbom peterbom merged commit f0493e0 into Azure:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix 🧑‍🔧 Implementation which intend to fix a behaviour. enhancement 🏎 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kube Objects collector only collects Pod descriptions, not other resource types
3 participants