Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/custom widget - deployed timestamp time zone #1942

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Fix/custom widget - deployed timestamp time zone #1942

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7881d0
WiP deployed timezone note
JMach1 Sep 3, 2022
19f1bb6
custom widget - deployed timestamp with timezone
JMach1 Sep 14, 2022
dfac79b
if -> ifnot fix
JMach1 Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts.v2/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function listFilesInDirectory(dir) {
}

/**
* Attempts to get a develoer portal storage connection string in two ways:
* Attempts to get a developer portal storage connection string in two ways:
* 1) if the connection string is explicitly set by the user, use it.
* 2) retrieving the connection string from the management API using the instance endpoint and SAS token
* @param {string} managementApiEndpoint the management endpoint of service instance
Expand Down
7 changes: 6 additions & 1 deletion src/components/custom-widget-list/createWidget.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,12 @@
<!-- ko if: !!$component.config -->
<p style="margin: 0;">
Last deployed<br/>
<span data-bind="text: $component.config.deployedOn ? new Date(config.deployedOn).toLocaleString() : 'The widget hasn\'t been deployed yet.'"></span>
<!-- ko if: !!$component.config.deployedOn -->
<span data-bind="text: new Date(config.deployedOn).toLocaleString(undefined, {timeZoneName: 'short'})"></span><br/>
<!-- /ko -->
<!-- ko if: !$component.config.deployedOn -->
JMach1 marked this conversation as resolved.
Show resolved Hide resolved
<span>The widget hasn't been deployed yet.</span>
<!-- /ko -->
</p>

<details>
Expand Down