Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabled popup controls and snippets. #2156

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Re-enabled popup controls and snippets. #2156

merged 3 commits into from
Apr 20, 2023

Conversation

azaslonov
Copy link
Member

@azaslonov azaslonov commented Apr 15, 2023

In this change we're gettin back the snippet for popup-based Menu and also adding the new "Popups" section to allow managing the popups.

@github-actions
Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 28 check(s) passed, and 24 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@f-alizada
Copy link
Collaborator

The PR bumps the version of the paperbits/style. Which results the error of fetching fonts, should it be added somewhere in the documentation how to retrieve/use?

@azaslonov
Copy link
Member Author

The PR bumps the version of the paperbits/style. Which results the error of fetching fonts, should it be added somewhere in the documentation how to retrieve/use?

I have added a placeholder for Google Fonts API key and sent the steps to the content team to produce the documentation.

@azaslonov azaslonov closed this Apr 19, 2023
@azaslonov azaslonov reopened this Apr 19, 2023
@azaslonov azaslonov merged commit 0b43193 into master Apr 20, 2023
@azaslonov azaslonov deleted the az/upgrade branch April 20, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants