Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dropdown for the case when there are multiple examples #2208

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Add dropdown for the case when there are multiple examples #2208

merged 4 commits into from
Jun 13, 2023

Conversation

f-alizada
Copy link
Collaborator

@f-alizada f-alizada commented Jun 13, 2023 •
edited
Loading

In case there are multiple examples of the request place them under dropdown select.

@github-actions
Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 28 check(s) passed, and 24 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

Mielek
Mielek requested changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@Mielek Mielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please invoke lint fix / prettier fix for styling

src/components/operations/operation-details/ko/runtime/operation-details.html Show resolved Hide resolved
src/components/operations/operation-details/ko/runtime/operation-details.ts Outdated Show resolved Hide resolved
src/components/operations/operation-details/ko/runtime/operation-details.ts Outdated Show resolved Hide resolved
src/components/operations/operation-details/ko/runtime/operation-details.ts Outdated Show resolved Hide resolved
@f-alizada f-alizada merged commit 518c428 into master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malincrist malincrist malincrist approved these changes

@Mielek Mielek Mielek approved these changes

@DeagleGross DeagleGross Awaiting requested review from DeagleGross

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@f-alizada @Mielek @DeagleGross @malincrist