Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed adding parameters for GraphQL APIs that already have parameters #2286

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

malincrist
Copy link
Member

Problem

Adding parameters from the test console for GraphQL APIs that already have a parameter in the URL results in miss-formatted URLs with double '?'
This problem occurs because our code checks for the '?' character only within the portion of the URL we create when adding query parameters.

Solution

Check for '?' throughout the entire URL, ensuring that we do not duplicate it.

Closes #2281

@github-actions
Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 29 check(s) passed, and 23 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@malincrist malincrist merged commit e393ad4 into master Sep 15, 2023
@malincrist malincrist deleted the malincrist/bug/gql-url-with-parameter branch September 15, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIM portal Developer Try It page - not sending subscription key in header
2 participants