Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed media empty permalink errors #2395

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

jsorohova
Copy link
Collaborator

@jsorohova jsorohova commented Feb 6, 2024

Problem:
Paperbits throw an error if empty permalink is defined for media files.

Solution:
Checking for empty string before making a request via paperbits.

Copy link

github-actions bot commented Feb 6, 2024

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 29 check(s) passed, and 23 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@jsorohova jsorohova merged commit 51a55fb into master Feb 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants