Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: API not loaded the first time #2424

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

malincrist
Copy link
Member

Problem

When navigating on a page that has API: Details widget, the first time the user selects an API (from the widget API: list for example), it is not loaded.
This is happening due to the order of the operations in the initialization flow: if there is no API in the URL initially we return without subscribing to onRouteChange(). Hence, even if the route changes, the API: Details widget doesn't react.

Solution

Subscribe to onRouteChange() even if there is no API in the URL.

Closes #2421

Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 29 check(s) passed, and 23 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@MarvinVaillant
Copy link

Thanks a lot for the fix :)

@malincrist malincrist merged commit 4cb8563 into master Feb 29, 2024
10 checks passed
@malincrist malincrist deleted the malincrist/bug/api-not-loaded-the-first-time branch February 29, 2024 08:38
@MarvinVaillant
Copy link

When can we expect the changes to be rolled out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"the specific api does not exist" shown if API is selected in api-details widget
3 participants