Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move default media files to regional storage (#2407)" #2461

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

malincrist
Copy link
Member

This reverts commit 4a51397.

Problem

After moving the default media file to regional containers, it was identified that, before the first publishing, they are not accessible by the publisher.
This is happening because Developer Portal returns the text with Learn more and instructions for publishing by default, when there is no revision. This default text is also returned instead of the images, hence they cannot be copied to tenant storage.

Solution

Revert the changes for now.

Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 29 check(s) passed, and 23 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@jsorohova jsorohova merged commit cd983ec into master Apr 12, 2024
9 checks passed
@jsorohova jsorohova deleted the malincrist/revert-move-default-media-files branch April 12, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants