Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tooltip button position and scrolling on subscription rename/cancel #2724

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fixed tooltip button position and scrolling on subscription rename/cancel #2724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/apis/details-of-api/ko/detailsOfApiEditor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<div class="label-group">
<label for="hyperlink" class="form-label">
Link to API changelog page
<button class="btn btn-info" type="button" title="Help" aria-label="Help"
data-bind="tooltip: 'A link to be navigated on click.'"></button>
</label>
<button class="btn btn-info" type="button" title="Help" aria-label="Help"
data-bind="tooltip: 'A link to be navigated on click.'"></button>
</div>
<div class="input-group">
<input id="hyperlink" type="text" class="form-control" disabled data-bind="value: hyperlinkTitle" />
Expand Down
6 changes: 3 additions & 3 deletions src/components/apis/list-of-apis/ko/listOfApisEditor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
<div class="label-group">
<label for="hyperlink" class="form-label">
Link to API details page
<button class="btn btn-info" type="button" aria-hidden="true" role="tooltip"
aria-label="A link to be navigated on click" data-bind="tooltip: 'A link to be navigated on click.'">
</button>
</label>
<button class="btn btn-info" type="button" aria-hidden="true" role="tooltip"
aria-label="A link to be navigated on click" data-bind="tooltip: 'A link to be navigated on click.'">
</button>
</div>
<div class="input-group">
<input type="text" id="hyperlink" class="form-control" disabled data-bind="value: hyperlinkTitle" />
Expand Down
2 changes: 1 addition & 1 deletion src/components/users/validation-summary/ko/runtime/validation-summary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ export class ValidationSummary {
this.errorMsgs(errorSum);
if (this.errorMsgs().length > 0) {
this.hasErrors(true);
document.getElementsByTagName(selector)[0]?.scrollIntoView();
} else {
this.hasErrors(false);
}

document.getElementsByTagName(selector)[0]?.scrollIntoView();
}
}
4 changes: 4 additions & 0 deletions src/themes/designer/styles/forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@
margin-bottom: 15px;
}

label.form-label {
position: relative;
}

&.form-group-collapsible {
& > .form-label {
position: unset;
Expand Down
Loading