Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json engines to require Node pre v20 #2731

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

Onatolich
Copy link
Collaborator

@Onatolich Onatolich commented Dec 6, 2024

Since Node.js v21 global.navigator is an immutable property and this code in paperbits core is making it impossible to publish:
https://github.com/paperbits/paperbits-core/blob/master/src/publishing/knockoutHtmlPagePublisherPlugin.ts#L29

image

Copy link

github-actions bot commented Dec 6, 2024

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 29 check(s) passed, and 23 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@Onatolich Onatolich requested a review from jsorohova December 6, 2024 15:54
@Onatolich Onatolich merged commit adf6b44 into master Dec 6, 2024
9 checks passed
@Onatolich Onatolich deleted the set-node-version branch December 6, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants