Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ProseMirror design-time css #694

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Move ProseMirror design-time css #694

merged 1 commit into from
Jun 11, 2020

Conversation

velsietis
Copy link
Contributor

@velsietis velsietis commented Jun 9, 2020

NOTE: Updated the pull request, see further comments below
I'm not sure why these white-space properties are necessary. I've had a go at removing them and none of the styling seems to break.

The reason I suggest removing them is that although it works fine when the published html is condensed onto a single line, if you format the document in a code editor, the styling breaks.

I came across the issue when trying to make adjustments to the html after the site has been published.

@azaslonov
Copy link
Member

Hi @velsietis, these styles are taken from prosemirror-view project, as recommended by their documentation. As far as I remember, there were nasty line-breaking issues.

Btw, when you say "if you format the document in a code editor", what do you mean and why would you do that after publishing? (just to be on the same page about the issue)

@velsietis
Copy link
Contributor Author

Thanks for the quick response.

The ProseMirror link made me realise I didn't check how removing that css affects the design-time view. It might break that but I'm pretty sure it's unnecessary once the site is has been published.

By format the document I mean adding line-breaks and indentation.

The reason we're doing that is to try to "stitch together" the published site with our documentation pages. They're all written in markdown, source controlled in GitHub and we use GitHub pages (Jekyll) to generate the site.

I was making a layout for the Jekyll site based off one of the index.html files in the published site when I encountered this issue with CSS.

@velsietis velsietis changed the title Remove "Brittle" white-space properties in css Move ProseMirror design-time css Jun 11, 2020
@velsietis
Copy link
Contributor Author

velsietis commented Jun 11, 2020

@azaslonov I've updated the pull request to move the styles instead of removing them. I've tested it locally and it seems to work fine and resolve the issue I originally mentioned.

@azaslonov
Copy link
Member

@velsietis, thank you, I don't see issues so far either. Moreover, having it in design styles actually makes total sense, this where it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants