Skip to content

Add priorityClassName to Helm Charts - Issue #1143 #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add priorityClassName to Helm Charts - Issue #1143 #1144

wants to merge 2 commits into from
+12 −5

Conversation

aglees
Copy link

@aglees aglees commented Feb 17, 2021

Checklist

  • The title of the PR is clear and informative
  • If applicable, the changes made in the PR have proper test coverage
  • Issues addressed by the PR are mentioned in the description followed by Fixes.

Description

Add an option in the Helm Chart for priorityClassName

Fixes

This addresses the feature request #1143

Sorry, something went wrong.

Andrew Gleeson added 2 commits February 17, 2021 11:52
Add priorityClassName to Helm Charts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
d833b9b
Fix linting
Loading
Loading status checks…
9fa285f
@ghost
Copy link

ghost commented Feb 17, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@akshaysngupta
Copy link
Member

akshaysngupta commented Mar 23, 2021 •
edited
Loading

@aglees can you add a helm render test.

  1. Update this file with the new parameter.
  2. Set env variable export RENDER_SNAPSHOTS="true"
  3. You can then check by running go test ./... in the folder.
  4. Check and Commit the snapshot

@JackStromberg JackStromberg added the feature New feature or request label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aglees @akshaysngupta @JackStromberg