On branch master: add inner template test case for Outputs-Must-Be-Present-In-Template-Parameters #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: arm-ttk/Test-AzTemplate.ps1 modified: arm-ttk/testcases/CreateUIDefinition/Outputs-Must-Be-Present-In-Template-Parameters.test.ps1 new file: unit-tests/Outputs-Must-Be-Present-In-Template-Parameters/Pass/InnerTemplate/azuredeploy.json new file: unit-tests/Outputs-Must-Be-Present-In-Template-Parameters/Pass/InnerTemplate/createUiDefinition.json
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: arm-ttk/Test-AzTemplate.ps1
On branch master: do not output the object info
bmoore-msft
reviewed
Nov 5, 2021
There was a problem hiding this comment.
Thanks for the fix - we think a more general fix is in order for this one, e.g. the test should never be called -- and there are some other tests that are being called even though they shouldn't be. It may take a few days to fix that so I'm going to merge this to unblock and then we may roll back some of these once that's done.
|
Thank you @bmoore-msft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error happens for
Outputs-Must-Be-Present-In-Template-Parameterstest case, when the main template has inner template, and the inner template does not have parameters the same from the UiDefinition outputs. It's super common usage. Such case should pass.Error message shows like: