Changing convertfrom-json utility usage based on powershell version (powershell 6+ has utility for json comments) #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raosuhas
reviewed
Nov 9, 2023
| @@ -1,5 +1,6 @@ | |||
| #region JSON Functions | |||
| if ($PSVersionTable.PSEdition -ne 'Core') { | |||
| #powershell 6+ provides support for json with comments | |||
There was a problem hiding this comment.
could you please update the description ? I am unableto understand the change made here ?
There was a problem hiding this comment.
Lets please update the descriptions for these ...Its really hard to figure out context on these PRs later
psah434
changed the title
raosuhas
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #737
Running the template provided in the above issue, if using the custom ConvertFrom-JSON utility, it fails.
The code change here changes the utility used to be the default powershell version if the powershell major version is equal to or above 6.
There is a small fix in the convertfrom-json utility where for recognizing comments both the starting and ending characters are searched.