Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added property serializedData in Template-Should-Not-Contain-Blanks T… #761

Conversation

v-rusraut
Copy link
Contributor

Ignore "serializedData" if it contain [] property.
After running tests locally we see below for the added test case on "serializedData" property :
image

@psah434
Copy link
Collaborator

psah434 commented Feb 14, 2024

Why should the property be empty? Is there public documentation regarding this? Also the test needs to change since serizliedData is not empty in the unit test

@v-rusraut
Copy link
Contributor Author

Here, we are not validating whether the serializedData property is empty. Instead, we are validating within serializedData to check if the property "Headers" are empty ([]). If so, we want to skip this property to avoid ARM TTK failures.
To resolve this ARM TTK error, we must manually remove this property from serializedData. Therefore, we believe it should not result in an ARM TTK failure.

@psah434
Copy link
Collaborator

psah434 commented Feb 14, 2024

Why should the property be empty? Is there public documentation regarding this?

Also if you want serializedData.Headers should be empty, can you change the code accordingly?

@v-rusraut
Copy link
Contributor Author

Here source file contains headers and columns property with []. That's why serializedData contains headers and columns property with []. so, we need to skip this validation.

image

Please refer documentation link: https://learn.microsoft.com/en-us/azure/azure-monitor/visualize/workbooks-automate#work-with-json-formatted-workbook-data-in-the-serializeddata-template-parameter

Thanks

@psah434 psah434 merged commit 6790eea into Azure:master Feb 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants