Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting headers in requests #1638

Closed
ArthurMa1978 opened this issue Oct 22, 2021 · 3 comments · Fixed by Azure/azure-sdk-for-net#26095
Closed

Support setting headers in requests #1638

ArthurMa1978 opened this issue Oct 22, 2021 · 3 comments · Fixed by Azure/azure-sdk-for-net#26095
Assignees
@archerzz
Labels
Docs Mgmt This issue is related to a management-plane library.
Milestone
[2022] January

Comments

@ArthurMa1978
Copy link
Member

ArthurMa1978 commented Oct 22, 2021 •
edited
Loading

This is from Citrix customers. They want the ability to set some custom headers in requests for analytics purpose.
More specifically, we have two scenarios:

  1. Allow Govind to identify
    all individual requests made as part of a broader “batch”. It sounds
    like correlation ID might be the right solution for this scenario.

  2. Allow Govind to identify
    all individual requests made as part of CVAD workload management.
    This scenario is more like the x-ms-client-scenario-id header that we
    introduced for Azure Resource Graph queries. Is the scenario ID
    header supported for CRM APIs? If not, is there an equivalent?
@ArthurMa1978 ArthurMa1978 added the Mgmt This issue is related to a management-plane library. label Oct 22, 2021
@ArthurMa1978 ArthurMa1978 mentioned this issue Oct 26, 2021
Closed
@ArthurMa1978
Copy link
Member Author

Developer can set custom headers by using RequestOptions, need to provide new API to support this function

@ArthurMa1978 ArthurMa1978 mentioned this issue Oct 29, 2021
Closed
@ArthurMa1978
Copy link
Member Author

Proposal: Use policy, need a doc.

@ArthurMa1978 ArthurMa1978 added this to the [2022] January milestone Dec 9, 2021
@archerzz archerzz added the Docs label Dec 21, 2021
@archerzz archerzz mentioned this issue Dec 28, 2021
Merged
11 tasks
archerzz added a commit to archerzz/azure-sdk-for-net that referenced this issue Dec 28, 2021
@archerzz
docs(core): improve pipeline sample
e8017e2 
- change some names
- split a new region `AddPerRetryPolicy`
- refine structure of `Pipeline.md` a little bit

resolve Azure/autorest.csharp#1638
@archerzz
Copy link
Member

There is already a doc in Azure.Core about how to use policy: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/samples/Pipeline.md

Anyway, I create a PR to improve it: Azure/azure-sdk-for-net#26095

@archerzz archerzz mentioned this issue Jan 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archerzz archerzz

Labels
Docs Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
[2022] January
Development

Successfully merging a pull request may close this issue.

docs(core): improve pipeline sample archerzz/azure-sdk-for-net
2 participants
@archerzz @ArthurMa1978