Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Operation helper types to Azure.Core #2231

Closed
annelo-msft opened this issue May 11, 2022 · 6 comments
Closed

Move Operation helper types to Azure.Core #2231

annelo-msft opened this issue May 11, 2022 · 6 comments
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. MQ This issue is part of a "milestone of quality" initiative. v3 Version 3 of AutoRest C# generator. WS: Code Generation
Milestone

Comments

@annelo-msft
Copy link
Member

annelo-msft commented May 11, 2022

We need to move the following files out of generator shared source in the autorest.csharp repo into Azure.Core shared source in the azure-sdk-for-net repo:

  • IOperationSource
  • LowLevelFuncOperation
  • LowLevelOperationHelpers
  • NextLinkOperationImplementation
  • OperationFinalStateVia
  • OperationInternals
  • OperationInternalsOfT
  • OperationOrResponseInternals
  • OperationOrResponseInternalsOfT
  • HttpPipelineExtensions

This is for two reasons:

  • We need to be able to modify operation types without being blocked by generator merge to repo processes
  • We need to consolidate all the operation types in a single place so we can begin refactoring and improving the LRO types as a unified story
@annelo-msft annelo-msft added Azure.Core Client This issue points to a problem in the data-plane of the library. DPG labels May 11, 2022
@annelo-msft
Copy link
Member Author

@AlexanderSher, @m-nash, do you have any concerns about this?

@ShivangiReja
Copy link
Member

There is an issue to move HttpPipelineExtensions methods to Azure.Core. Can we do this as a part of this issue?

@AlexanderSher
Copy link
Contributor

AlexanderSher commented May 11, 2022

These types should be just removed:

OperationOrResponseInternals
OperationOrResponseInternalsOfT

Also, we need to fix generated code so that OperationInternals and OperationInternalsOfT are not used anywhere and get rid of them as well.

@annelo-msft
Copy link
Member Author

@AlexanderSher, by removed, do you mean deleted from both repos?

@annelo-msft annelo-msft changed the title Move DPG Operation helper types to Azure.Core Move Operation helper types to Azure.Core May 11, 2022
@AlexanderSher
Copy link
Contributor

We should also try to get rid of IOperationSource, but that is more complicated thing to do.

@annelo-msft
Copy link
Member Author

Duplicate of Azure/azure-sdk-for-net#28369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. MQ This issue is part of a "milestone of quality" initiative. v3 Version 3 of AutoRest C# generator. WS: Code Generation
Projects
None yet
Development

No branches or pull requests

6 participants