Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move generator HttpPipelineExtensions methods to Azure.Core #27483

Closed
ShivangiReja opened this issue Mar 10, 2022 · 4 comments
Closed

Move generator HttpPipelineExtensions methods to Azure.Core #27483

ShivangiReja opened this issue Mar 10, 2022 · 4 comments
Assignees
@AlexanderSher
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. MQ This issue is part of a "milestone of quality" initiative.
Milestone
Backlog

Comments

@ShivangiReja
Copy link
Member

Library name

Azure.Core

Please describe the feature.

HttpPipelineExtensions class exists in Generator.Shared and it has ProcessMessage methods which we use in DPG methods. Here is an example of how do we use these methods in DPG.

I think we should move all the methods from HttpPipelineExtensions to Azure.Core as it can be useful for the cases when someone has to handwrite the DPG methods.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 10, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Extensions:0.4857908,Azure.Core:0.28164512,Storage:0.117870994'

@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 10, 2022
@ShivangiReja
Copy link
Member Author

CC: @annelo-msft

@jsquire jsquire added the Client This issue points to a problem in the data-plane of the library. label Mar 10, 2022
@annelo-msft annelo-msft self-assigned this Mar 18, 2022
@christothes christothes added this to the [2022] May milestone Mar 28, 2022
@annelo-msft annelo-msft modified the milestones: [2022] May, Backlog Apr 1, 2022
@ShivangiReja ShivangiReja mentioned this issue May 11, 2022
Closed
@annelo-msft annelo-msft added the MQ This issue is part of a "milestone of quality" initiative. label Oct 20, 2022
@annelo-msft annelo-msft removed their assignment Oct 25, 2022
@heaths
Copy link
Member

heaths commented Oct 25, 2022

Do we make these public extension methods, or as shared source in Core?

@heaths heaths modified the milestones: Backlog, 2023-01 Oct 25, 2022
@jsquire jsquire modified the milestones: 2023-01, Backlog Jan 19, 2023
@annelo-msft
Copy link
Member

Closing as duplicate of #32006

@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AlexanderSher AlexanderSher

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. MQ This issue is part of a "milestone of quality" initiative.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@jsquire @christothes @heaths @AlexanderSher @annelo-msft @ShivangiReja @azure-sdk