Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SubResourceWriterable to WriteableSubResource #1249

Merged
merged 6 commits into from
May 18, 2021
Merged

Update SubResourceWriterable to WriteableSubResource #1249

merged 6 commits into from
May 18, 2021

Conversation

JonathanCrd
Copy link
Member

Description

Update Azure.ResourceManager.Core version to this PR, and update all references for SubResourceWriterable to WriteableSubResource.

ADO item 5844.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

chamons
chamons reviewed May 18, 2021
View reviewed changes
Copy link
Contributor

@chamons chamons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changed in shared code. Seems reasonable enough but fully a mgmt PR to review.

@m-nash m-nash merged commit dca942f into Azure:feature/v3 May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chamons chamons chamons left review comments

@m-nash m-nash m-nash approved these changes

@markcowl markcowl Awaiting requested review from markcowl

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@YalinLi0312 YalinLi0312 Awaiting requested review from YalinLi0312

@nisha-bhatia nisha-bhatia Awaiting requested review from nisha-bhatia

@pakrym pakrym Awaiting requested review from pakrym

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja

Assignees

@m-nash m-nash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonathanCrd @chamons @m-nash