Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ResourceManager core version and Fix tuple resource issues #1323

Merged
merged 4 commits into from
Jun 22, 2021

Conversation

ShivangiReja
Copy link
Member

@ShivangiReja ShivangiReja commented Jun 17, 2021

Description

https://dev.azure.com/azure-mgmt-ex/DotNET%20Management%20SDK/_backlogs/backlog/DotNET%20Management%20SDK%20Team/Features/?showParents=true&workitem=5974

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@isra-fel
Copy link
Member

Hi I pushed a new commit to not generate Container.Get() and GetAsync() with override keyword. This is depending on Azure/azure-sdk-for-net#21963 and a new build of Arm.Core

@ShivangiReja ShivangiReja marked this pull request as ready for review June 22, 2021 20:22
Copy link
Contributor

@chamons chamons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major shared code impact - 👍

@ShivangiReja ShivangiReja merged commit 7e4337f into Azure:feature/v3 Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants