Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dpg): path/url parameters not ordered by optional value #2779

Merged
merged 11 commits into from
Oct 26, 2022
Merged

fix(dpg): path/url parameters not ordered by optional value #2779

merged 11 commits into from
Oct 26, 2022

Conversation

archerzz
Copy link
Member

  • revert previous commit to fix this issue
  • sort path/url parameters, put required ones at the beginning, and put optional ones after body parameter
  • add test cases

fix #2766

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@archerzz archerzz mentioned this pull request Oct 17, 2022
Merged
6 tasks
@archerzz archerzz requested a review from allenjzhang as a code owner October 18, 2022 04:08
@archerzz
fix(dpg): path/url parameters not ordered by optional value
caa6776 
- revert previous commit to fix this issue
- sort path/url parameters, put required ones at the beginning, and put optional ones after body parameter
- add test cases

fix Azure#2766
@archerzz
fix broken test
102f3ef
@archerzz
add parameter order test for mgmt sdk
03721b1
@archerzz
add cadl test
c08f057
@archerzz
add a test case containing both optional path and body parameters
5dcf604
@archerzz
regen after rebase
d465c76
@AlexanderSher AlexanderSher merged commit 1820af3 into Azure:feature/v3 Oct 26, 2022
@archerzz archerzz mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSher AlexanderSher AlexanderSher approved these changes

@lirenhe lirenhe Awaiting requested review from lirenhe

@chunyu3 chunyu3 Awaiting requested review from chunyu3

@m-nash m-nash Awaiting requested review from m-nash

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutoRest C# generator generating DPG code with compilation errors
2 participants
@archerzz @AlexanderSher