-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and fixes in source input model #3445
Merged
ArcturusZhang
merged 7 commits into
Azure:feature/v3
from
ArcturusZhang:refactor-and-fixes-in-source-input-model
May 31, 2023
Merged
Refactor and fixes in source input model #3445
ArcturusZhang
merged 7 commits into
Azure:feature/v3
from
ArcturusZhang:refactor-and-fixes-in-source-input-model
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
requested review from
m-nash,
jsquire,
lirenhe and
ArthurMa1978
as code owners
May 29, 2023 05:05
The changes in the regen is the same as the changes in the auto PR triggered on feature/v3 |
ArcturusZhang
commented
May 29, 2023
lirenhe
reviewed
May 29, 2023
lirenhe
reviewed
May 29, 2023
chunyu3
reviewed
May 30, 2023
chunyu3
approved these changes
May 30, 2023
lirenhe
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we have quite a few attributes to pass around, this PR introduces a new class to have them all.
This PR also fixes a key conflicts when a member has both serialization attributes (
CodeGenMemberSerialization
andCodeGenMemberSerializationHooks
)Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?