Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and fixes in source input model #3445

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented May 29, 2023

Description

Since we have quite a few attributes to pass around, this PR introduces a new class to have them all.

This PR also fixes a key conflicts when a member has both serialization attributes (CodeGenMemberSerialization and CodeGenMemberSerializationHooks)

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang
Copy link
Member Author

The changes in the regen is the same as the changes in the auto PR triggered on feature/v3

@ArcturusZhang ArcturusZhang merged commit 73e1a47 into Azure:feature/v3 May 31, 2023
@ArcturusZhang ArcturusZhang deleted the refactor-and-fixes-in-source-input-model branch May 31, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants